Skip to content

Conversation

@forsyth2
Copy link
Collaborator

@forsyth2 forsyth2 commented Oct 5, 2023

Automate zppy tests. Resolves #516.

@forsyth2 forsyth2 added the Testing Files in `tests` modified label Oct 5, 2023
@forsyth2 forsyth2 self-assigned this Oct 5, 2023
exit 1
fi

exit 7
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Exiting here for now, since the subsequent steps are difficult to automate.

@forsyth2
Copy link
Collaborator Author

forsyth2 commented Oct 5, 2023

@chengzhuzhang This is an initial attempt at automating the steps from https://e3sm-project.github.io/zppy/_build/html/main/dev_guide/release_testing.html -- specifically just the a. test dev steps, since that is more useful in the near-term. Once I get that working, I'm planning to make a different script for the other two cases.

There's a number of issues in fully automating this workflow. See the #TODO in-line comments.

if __name__ == "__main__":
generate_cfgs(unified_testing=False)
generate_cfgs(
unified_testing=(sys.argv[1] == "True"), diags_environment_commands=sys.argv[2]
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be args 2 and 3

@forsyth2
Copy link
Collaborator Author

forsyth2 commented Dec 14, 2024

Made some adjustments post-zppy/zppy-interfaces split. Can't run these changes yet because need to get around 1) issues with conda activation in a script and 2) automating the waiting for multiple jobs to finish.

fi
git reset --hard upstream/main
conda clean --all --y
# TODO: previous iterations of this script had issues with activating conda environments
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably need the conda sourcing command too: e.g., source /gpfs/fs1/home/ac.forsyth2/miniforge3/etc/profile.d/conda.sh


# Set up zppy-interfaces env
cd ${ZI_DIR}
git fetch upstream main
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Even simple lines like this are going to require user input on systems that require GitHub passphrases every time fetch is run.

Comment on lines +14 to +16
ZPPY_DIR=/home/ac.forsyth2/zppy/
DIAGS_DIR=/home/ac.forsyth2/e3sm_diags/
ZI_DIR=/home/ac.forsyth2/zppy-interfaces/
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Or we need to have the script do git clone fresh...

@forsyth2 forsyth2 mentioned this pull request Apr 8, 2025
7 tasks
@forsyth2
Copy link
Collaborator Author

#709 replaces the work in this PR.

@forsyth2 forsyth2 closed this Apr 11, 2025
@forsyth2 forsyth2 deleted the issue-516 branch October 20, 2025 17:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Testing Files in `tests` modified

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Further automate tests

2 participants